fix(logger-utils): ensure external loggers doesn't propagate logs on config copy

[mploski]

Issue #, if available:

#1073

Description of changes:

Ensure external loggers doesn't propagate logs to root logger by disabling Propagate attribute. Previously event was emitted in external logger ( with powertools handler) and in root handler IF propagation was set to True. This change ensure log is only emitted by external logger handler.

Also, during debugging noticed that we don't exclude aws_lambda_powertools from handler modification since this is root powertools package we might treat it as internal package and skip applying powertools logger handler. @heitorlessa please correct me if I'm wrong here

Checklist

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

• Migration process documented
• Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[mploski]

@heitorlessa please review

[heitorlessa]

Additional test to ensure we don't break child loggers

[codecov-commenter]

Codecov Report

Merging #1075 (3c4df97) into develop (565d0a5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1075   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5373     5376    +3     
  Branches       613      613           
========================================
+ Hits          5371     5374    +3     
  Partials         2        2           

Impacted Files	Coverage Δ
aws_lambda_powertools/logging/utils.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 565d0a5...3c4df97. Read the comment docs.

[heitorlessa]

@mploski made a performance change (package_logger as constant over logger instance), removed an unnecessary test, and repurposed that child logger test to cover the rule of not touching child loggers.

I'll merge and make a release once you're okay with it

[heitorlessa]

In another PR, it's worth cleaning up the test functions/fixtures as I noticed they're duplicated from functional/test_logger - in this case, it's easier to have a logger utils for our tests and easily reuse via import (low priority)

[mploski]

@mploski made a performance change (package_logger as constant over logger instance), removed an unnecessary test, and repurposed that child logger test to cover the rule of not touching child loggers.

I'll merge and make a release once you're okay with it

We need to also cover one blind spot to not break passing keys between child and parent. We may either prohibit from passing child logger as source to this method our automatically decapsulate parent logger and exclude it from modification to avoid setting propagate=False as it breaks things.

Added fix for this specific part in latest commit. Please review it and if it works for you we can merge it

[heitorlessa]

Awesome, checking as soon as I finish one last meeting