Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix syntax errors in the lambda layer terraform example #1068

Closed
wants to merge 9 commits into from
Closed

fix(docs): fix syntax errors in the lambda layer terraform example #1068

wants to merge 9 commits into from

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Mar 8, 2022 •
edited
Loading

Issue #, if available:

Description of changes:

Changes:

  • Fix the line number highlight for the lambda layer
  • aws provider needs to be a newer version to support python3.9 runtime
  • Use jsonencode instead of <<EOF to fix the formatting of the terraform snippet
  • run terraform fmt

Confirmed changes by:

  • terraform init
  • tflint
  • terraform plan

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

View rendered docs/index.md

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2022
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 8, 2022
@github-actions github-actions bot added the bug Something isn't working label Mar 8, 2022
@michaelbrewer michaelbrewer changed the title fix(docs): Correct the terraform example fix(docs): correct the main lambda layer terraform example Mar 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #1068 (21c2798) into develop (0d12384) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1068   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5377     5377           
  Branches       613      613           
========================================
  Hits          5375     5375           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d12384...21c2798. Read the comment docs.

@michaelbrewer michaelbrewer changed the title fix(docs): correct the main lambda layer terraform example fix(docs): correct the index.md lambda layer terraform example Mar 8, 2022
@michaelbrewer michaelbrewer changed the title fix(docs): correct the index.md lambda layer terraform example fix(docs): correct syntax error the index.md lambda layer terraform example Mar 14, 2022
@heitorlessa heitorlessa removed the bug Something isn't working label Mar 15, 2022
@michaelbrewer michaelbrewer changed the title fix(docs): correct syntax error the index.md lambda layer terraform example fix(docs): fix broken syntax error the index.md lambda layer terraform example Apr 2, 2022
@github-actions github-actions bot added the bug Something isn't working label Apr 2, 2022
@michaelbrewer michaelbrewer changed the title fix(docs): fix broken syntax error the index.md lambda layer terraform example fix(docs): fix broken syntax error in the lambda layer terraform example Apr 2, 2022
@michaelbrewer michaelbrewer changed the title fix(docs): fix broken syntax error in the lambda layer terraform example fix(docs): fix syntax error in the lambda layer terraform example Apr 2, 2022
@michaelbrewer michaelbrewer changed the title fix(docs): fix syntax error in the lambda layer terraform example fix(docs): fix syntax errors in the lambda layer terraform example Apr 2, 2022
@michaelbrewer
Copy link
Contributor Author

Replaced by #1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbrewer @codecov-commenter @heitorlessa