fix: regression 104 #105
Merged
fix: regression 104 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #105 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 497 499 +2
Branches 45 46 +1
=========================================
+ Hits 497 499 +2
Continue to review full report at Codecov.
|
zroger
reviewed
Aug 14, 2020
| """ Returns preferred log level set by the customer in upper case """ | ||
| if isinstance(level, int): | ||
| return level | ||
|
|
||
| log_level: str = level or os.getenv("LOG_LEVEL") |
There was a problem hiding this comment.
The docstring on line 47 above declares the LOG_LEVEL environment variable as capable of accepting an integer. That probably needs to be handled here as well.
There was a problem hiding this comment.
handling that in another PR before publishing it, as the test didn't go through
Signed-off-by: heitorlessa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #105 104
Description of changes:
Corrects regression where
Loggerconstructor wasn't takingintas a level.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.