Some code suggestion from CodeGuru #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @XinyuLiu5566 Thanks for opening the PR. There seems to be some failing tests. Can you please look into it ? |
| @@ -46,7 +46,8 @@ public void remove(String Key){ | |||
| } | |||
|
|
|||
| public Object get(String key) { | |||
| return store.containsKey(key)?store.get(key).value:null; | |||
| ValueNode node = store.get(key); | |||
| return node ? node.value : null; | |||
There was a problem hiding this comment.
@XinyuLiu5566 - this would fix the runtime error
Suggested change
| return node ? node.value : null; | |
| return node != null ? node.value : null; |
…ertools/parameters/cache/DataStore.java Co-authored-by: Michael Brewer <[email protected]>
jeromevdl
pushed a commit
that referenced
this pull request
Nov 15, 2022
* avoid repeated get() * %s to %d for integer * change put() to putIfAbsent() * Update powertools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/cache/DataStore.java Co-authored-by: Michael Brewer <[email protected]> * Fix logic for caching json schema. Co-authored-by: liuxinyu <[email protected]> Co-authored-by: Pankaj Agrawal <[email protected]> Co-authored-by: Michael Brewer <[email protected]>
|
Thanks @jeromevdl for merging #984. Could you please close this PR, as it contains the same changes and my PR was created just to fix some issues with this one. |
|
Fixed with #984 |
jeromevdl
pushed a commit
that referenced
this pull request
Nov 24, 2022
* avoid repeated get() * %s to %d for integer * change put() to putIfAbsent() * Update powertools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/cache/DataStore.java Co-authored-by: Michael Brewer <[email protected]> * Fix logic for caching json schema. Co-authored-by: liuxinyu <[email protected]> Co-authored-by: Pankaj Agrawal <[email protected]> Co-authored-by: Michael Brewer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is using ConcurrentHashMap, but the usage of containsKey() and get() may not be thread-safe. In between the check and the get() another thread can remove the key and the get() will return null. Fix:
Consider calling get(), checking instead of your current check if the returned object is null, and then using that object only, without calling get() again.
This code uses '%s' to format int: 'size' expression. Use %d, not %s, for integers. This ensures locale-sensitive formatting.
Replacing put() with putIfAbsent() to help prevent accidental overwriting. putIfAbsent() puts the value only if the ConcurrentHashMap does not contain the key and therefore avoids overwriting the value written there by the other thread's putIfAbsent().