Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get Trace ID from System property, when Env Var is not set #1501 #1502

Closed
wants to merge 4 commits into from
Closed

fix: Get Trace ID from System property, when Env Var is not set #1501 #1502

wants to merge 4 commits into from

Conversation

mriccia
Copy link
Contributor

@mriccia mriccia commented Nov 8, 2023 •
edited
Loading

Issue #, if available: #1501

Description of changes:

If the _X_AMZN_TRACE_ID env var is not set, check the com.amazonaws.xray.traceHeader system property.

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mriccia mriccia changed the title WIP: Issue 1501 fix: Get Trace ID from System property, when Env Var is not set #1501 Nov 8, 2023
@mriccia mriccia marked this pull request as ready for review November 8, 2023 11:37
@mriccia mriccia requested a review from jeromevdl November 8, 2023 11:55
jeromevdl
jeromevdl approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mriccia
Copy link
Contributor Author

mriccia commented Nov 8, 2023

Closing this PR in favour of #1503

@mriccia mriccia closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromevdl jeromevdl jeromevdl approved these changes

Assignees

@mriccia mriccia

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mriccia @jeromevdl