Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Started cleaning up example doc #1291

Merged
merged 19 commits into from
Jul 20, 2023
Merged

docs: Started cleaning up example doc #1291

merged 19 commits into from
Jul 20, 2023

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Jul 17, 2023

Issue #, if available:
#1289

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl jeromevdl changed the title doc: Started cleaning up example doc Doc: Started cleaning up example doc Jul 18, 2023
@jeromevdl jeromevdl changed the title Doc: Started cleaning up example doc docs: Started cleaning up example doc Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.24 🎉

Comparison is base (c7aedc4) 78.94% compared to head (b89594d) 79.19%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1291      +/-   ##
============================================
+ Coverage     78.94%   79.19%   +0.24%     
- Complexity      629      639      +10     
============================================
  Files            72       73       +1     
  Lines          2332     2360      +28     
  Branches        253      258       +5     
============================================
+ Hits           1841     1869      +28     
+ Misses          412      410       -2     
- Partials         79       81       +2     
Impacted Files Coverage Δ
...powertools/idempotency/persistence/DataRecord.java 73.17% <ø> (ø)
...lambda/powertools/parameters/DynamoDbProvider.java 80.32% <8.33%> (-3.01%) ⬇️
.../lambda/powertools/parameters/SecretsProvider.java 65.85% <10.00%> (-0.82%) ⬇️
...azon/lambda/powertools/parameters/SSMProvider.java 87.14% <70.00%> (+6.26%) ⬆️
...oftware/amazon/lambda/powertools/sqs/SqsUtils.java 79.72% <95.23%> (+4.72%) ⬆️
...mpotency/persistence/DynamoDBPersistenceStore.java 88.19% <100.00%> (+0.08%) ⬆️
...zon/lambda/powertools/parameters/ParamManager.java 77.77% <100.00%> (+0.85%) ⬆️
...ption/SkippedMessageDueToFailedBatchException.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scottgerring scottgerring marked this pull request as ready for review July 19, 2023 12:54
examples/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc is good, just rename Powertools for AWS Lambda Java everywhere

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottgerring scottgerring merged commit 0ac8127 into main Jul 20, 2023
@scottgerring scottgerring deleted the example-docs branch July 20, 2023 09:52
jeromevdl added a commit that referenced this pull request Jul 25, 2023
* Started cleaning up example doc

* More work

* More docs

* More docs

* More docs

* Clean up SQS

* Did validationg

* Consistency

* Add CF

* More cleanp

* Add magic back

* Update examples/README.md

Co-authored-by: Jérôme Van Der Linden <[email protected]>

* Fix naming

* fix syntax

---------

Co-authored-by: Jérôme Van Der Linden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants