-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reporting size of the jars in GitHub comments #1196
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
============================================
- Coverage 78.93% 78.57% -0.36%
+ Complexity 651 650 -1
============================================
Files 74 74
Lines 2506 2506
Branches 259 259
============================================
- Hits 1978 1969 -9
- Misses 446 455 +9
Partials 82 82 ☔ View full report in Codecov by Sentry. |
4525624
to
6f25393
Compare
💾 Artifacts Size Report
|
657795e
to
50c01a6
Compare
Help: How can we compare with previous versions of each artifact? (ideally from maven central or any other way) |
Hey @jeromevdl can we be of any help here? |
@scottgerring Yes, for the moment I report the size of the built artifacts. Ideally I'd like to compare with the current release to see if it grows or not, but not sure how to achieve this... |
824e3aa
to
17945c8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
My idea for the comparison with previous versions:
We'll do that when refactoring the release process... We can already merge the report itself. Ready for review! |
Can we do this with sonar custom metrics? |
17945c8
to
2dd3222
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Will push that initial version without comparison with previous versions. |
* reporting size of the jars in the github comments
Issue #, if available: #1102
Description of changes:
Display a report in GitHub comments about jars size. (Ideally would be great to have the history and see if it's growing)
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.