Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java-based cfn-response module #558

Closed
bdkosher opened this issue Sep 27, 2021 · 3 comments
Closed

Java-based cfn-response module #558

bdkosher opened this issue Sep 27, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@bdkosher
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There's a cfn-response module to support Lambda-backed AWS CloudFormation custom resources, but it's only available for Node and Python runtimes.

Describe the solution you'd like
A cfn-module equivalent for Java.

Describe alternatives you've considered
Lambda authors must create their own Java equivalent or use a supported runtime.
@msailes
Copy link
Contributor

msailes commented Sep 28, 2021

I think this would be helpful to customers, and it would save them a task.

Even better if we could then update the docs.

@heitorlessa
Copy link
Contributor

cc @richardhboyd in case that's been discussed before somewhere else

bdkosher pushed a commit to bdkosher/aws-lambda-powertools-java that referenced this issue Sep 28, 2021
Create Java cfn-response equivalent (aws-powertools#558)
8b5b0e2 
Introduces Java implementation of cfn-response module based on NodeJS design.
Put the sole class in a separate powertools-cloudformation Maven module.
100% code coverage

Addresses aws-powertools#558
@bdkosher bdkosher mentioned this issue Sep 28, 2021
Merged
6 tasks
bdkosher pushed a commit to bdkosher/aws-lambda-powertools-java that referenced this issue Oct 6, 2021
Create Java cfn-response equivalent (aws-powertools#558)
1bea4ca 
Introduces Java implementation of cfn-response module based on NodeJS design.
Put the sole class in a separate powertools-cloudformation Maven module.
100% code coverage

Addresses aws-powertools#558
bdkosher pushed a commit to bdkosher/aws-lambda-powertools-java that referenced this issue Oct 6, 2021
Add base RequestHandler class for custom resources
7abe871 
Provides abstract methods for generating the Response to be sent,
represented as its own type. Use Objects::nonNull instead of custom
method.

Addresses aws-powertools#558
bdkosher pushed a commit to bdkosher/aws-lambda-powertools-java that referenced this issue Oct 18, 2021
Create Java cfn-response equivalent (aws-powertools#558)
b087302 
Introduces Java implementation of cfn-response module based on NodeJS design.
Put the sole class in a separate powertools-cloudformation Maven module.
100% code coverage

Addresses aws-powertools#558
bdkosher pushed a commit to bdkosher/aws-lambda-powertools-java that referenced this issue Oct 18, 2021
Add base RequestHandler class for custom resources
81ce911 
Provides abstract methods for generating the Response to be sent,
represented as its own type. Use Objects::nonNull instead of custom
method.

Addresses aws-powertools#558
bdkosher pushed a commit to bdkosher/aws-lambda-powertools-java that referenced this issue Oct 22, 2021
Create Java cfn-response equivalent (aws-powertools#558)
2f1636a 
Introduces Java implementation of cfn-response module based on NodeJS design.
Put the sole class in a separate powertools-cloudformation Maven module.
100% code coverage

Addresses aws-powertools#558
bdkosher pushed a commit to bdkosher/aws-lambda-powertools-java that referenced this issue Oct 22, 2021
Add base RequestHandler class for custom resources
5e835ae 
Provides abstract methods for generating the Response to be sent,
represented as its own type. Use Objects::nonNull instead of custom
method.

Addresses aws-powertools#558
pankajagrawal16 pushed a commit that referenced this issue Oct 26, 2021
@bdkosher
feat: create Java cfn-response equivalent (#558) (#560)
35ad5f6 
* Create Java cfn-response equivalent (#558)

Introduces Java implementation of cfn-response module based on NodeJS design.
Put the sole class in a separate powertools-cloudformation Maven module.
100% code coverage

Addresses #558

* Add base RequestHandler class for custom resources

Provides abstract methods for generating the Response to be sent,
represented as its own type. Use Objects::nonNull instead of custom
method.

Addresses #558

* Put Response body attributes (status, noEcho, etc) in Response builder itself

Instead of method args to various CloudFormationResponse::send methods, reducing the number of polymorphic send
methods to two: one with a Response arg and one without.

Rename ResponseException to CustomResourceResponseException.

AbstractCustomResourceHandlerTest simplifications.

* Lock down CloudFormationResponse; default SdkHttpClient

- Include powertools-cloudformation in .github config
- Address mutatable ObjectMapper spotbugs finding
- JavaDoc cleanup

* Cloudformation module documentation

* CloudFormation documentation tweaks

* Include custom resources doc in menu

Co-authored-by: Joe Wolf <[email protected]>
@pankajagrawal16
Copy link
Contributor

Released as part of https://github.com/awslabs/aws-lambda-powertools-java/releases/tag/v1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jeromevdl @bdkosher @heitorlessa @pankajagrawal16 @msailes