-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatic Register XRay for all services #428
feat: Automatic Register XRay for all services #428
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
===========================================
- Coverage 72.66% 72.54% -0.12%
===========================================
Files 82 82
Lines 3644 3650 +6
===========================================
Hits 2648 2648
- Misses 996 1002 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test for the two new methods?
Issue number: #249
Summary
This PR adds a thin wrapper around AWSSDKHandler.RegisterXRayForAllServices() andAWSSDKHandler.RegisterXRay()
Changes
Adds two wrapper static methods to Tracing class.
User experience
User now can call following wrapper methods instead of sdk methods
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.