Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix flux java dashboard #288

Merged

Conversation

hmuthusamy
Copy link
Contributor

What does this PR do?

Resolved the issue when enabling nginx,java and istio dashboards causes it to create the dashboard before the fluxcd chart is installed. so added a depends on to ensure fluxcd is installed first.

Motivation

More

  • [ X] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ X] Yes, I ran pre-commit run -a with this PR
  • [ X] Yes, I have added a new example under examples to support my PR (when applicable)
  • [ x] Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

elamaran11
elamaran11 previously approved these changes Oct 30, 2024
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @bonclay7 This is fix for breaking issue

@hmuthusamy
Copy link
Contributor Author

@bonclay7 Seems like same issue on pre-commit. It ran fine locally for me on this PR

There are some problems with the CLI configuration:

│ Error: The specified plugin cache dir /home/runner/work/terraform-aws-observability-accelerator/terraform-aws-observability-accelerator/.terraform.d/plugin-cache cannot be opened: stat /home/runner/work/terraform-aws-observability-accelerator/terraform-aws-observability-accelerator/.terraform.d/plugin-cache: no such file or directory

@bonclay7 bonclay7 merged commit 0fe3950 into aws-observability:main Oct 31, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants