Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AWS managed agentless collector for Prometheus metrics #260

Closed

Conversation

RAMathews
Copy link
Contributor

@RAMathews RAMathews commented Jan 18, 2024

This PR implements AWS-managed scrapers. Prometheus metrics will be scraped directly by AMP, with higher availability, security and scalability. ADOT will still remain for OTLP traces, metrics and cross {region, account} scenarios

  • Docs update
  • Limitations (cross region and account)
  • Provide choice between managed scrapers and full ADOT (enable variable)

What does this PR do?

Added AWS managed collector resource and prometheus configuration.
Edited opentelemetry collector configuration to remove some of the prometheus scrape jobs.

Motivation

Implement this new feature: https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-managed-service-prometheus-agentless-collector-metrics-eks/ in Observability accelerator.

More

Currently testing this setup in my local account.

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

…d removed some of the prometheus scrape jobs from ADOT config
@RAMathews RAMathews changed the title added prometheus configuration, managed prometheus scraper resoure an… Implement AWS managed agentless collector for Prometheus metrics Jan 18, 2024
@RAMathews RAMathews marked this pull request as draft January 18, 2024 16:19
Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to test this, please run pre-commit to lint your code as well

modules/eks-monitoring/main.tf Outdated Show resolved Hide resolved
modules/eks-monitoring/main.tf Outdated Show resolved Hide resolved
Copy link

This PR has been automatically marked as stale because it has been open 60 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 19, 2024
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants