-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AWS managed agentless collector for Prometheus metrics #260
Closed
RAMathews
wants to merge
9
commits into
aws-observability:main
from
RAMathews:managed-prometheus-collector
Closed
Implement AWS managed agentless collector for Prometheus metrics #260
RAMathews
wants to merge
9
commits into
aws-observability:main
from
RAMathews:managed-prometheus-collector
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d removed some of the prometheus scrape jobs from ADOT config
RAMathews
changed the title
added prometheus configuration, managed prometheus scraper resoure an…
Implement AWS managed agentless collector for Prometheus metrics
Jan 18, 2024
bonclay7
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't wait to test this, please run pre-commit to lint your code as well
- Allow scraper to be created with eks subnets lie in multiple azs - identify metrics coming from the scraper vs collector - output aws-auth as a one liner command line
This PR has been automatically marked as stale because it has been open 60 days |
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements AWS-managed scrapers. Prometheus metrics will be scraped directly by AMP, with higher availability, security and scalability. ADOT will still remain for OTLP traces, metrics and cross {region, account} scenarios
enable
variable)What does this PR do?
Added AWS managed collector resource and prometheus configuration.
Edited opentelemetry collector configuration to remove some of the prometheus scrape jobs.
Motivation
Implement this new feature: https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-managed-service-prometheus-agentless-collector-metrics-eks/ in Observability accelerator.
More
Currently testing this setup in my local account.
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes