Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make dashboard configurations overridable #232

Merged
merged 1 commit into from
Sep 26, 2023
Merged

chore: Make dashboard configurations overridable #232

merged 1 commit into from
Sep 26, 2023

Conversation

bonclay7
Copy link
Member

What does this PR do?

Linked to #223

This will allow dashboard config objects defaults to be overriden.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bonclay7 bonclay7 requested a review from lewinkedrs September 26, 2023 15:03
lewinkedrs
lewinkedrs approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@lewinkedrs lewinkedrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewinkedrs lewinkedrs merged commit 79559d0 into main Sep 26, 2023
34 checks passed
@bonclay7 bonclay7 deleted the chore/default-vars-for-dashboards branch September 26, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewinkedrs lewinkedrs lewinkedrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonclay7 @lewinkedrs