Adding Module and Example for ECS cluster monitoring with ecs_observer

[ruchimo]

What does this PR do?

Adding Module and Example for ECS cluster monitoring with ecs_observer

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Part of the virtual Hackathon on the AWS Observability Accelerator.

More

• Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
• Yes, I ran pre-commit run -a with this PR
• Yes, I have added a new example under examples to support my PR (when applicable)
• Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

• E2E Test successfully complete before merge?

Additional Notes

[bonclay7]

examples/ecs-cluster-with-vpc

Normally we try to keep examples as lean as possible to simplify maintenance. Normally ecs-cluster-with-vpc should be flat and not nested. We usually have an apply-able main.tf in the examples. Here's it's not clear what we are testing.
Additionally there's a quite popular module actively maintained, maybe we should just reuse it and focus on our added value? https://github.com/terraform-aws-modules/terraform-aws-ecs but maybe I'm missing something?

[bonclay7]

When we finish the example, that use the new module, we should add a little doc https://aws-observability.github.io/terraform-aws-observability-accelerator/ on ECS monitoring as well

[bonclay7]

@ruchimo any updates on this?

[bonclay7]

@ruchimo please let me know when I ca re-review

[ruchimo]

@bonclay7 - Please review....

[bonclay7]

@ruchimo please check the broken tests

https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/6048526849/job/16418900113?pr=211
https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/6048526849/job/16418897812?pr=211

Also please install and run pre-commit, you can find instructions here

[ruchimo]

@ruchimo please check the broken tests

https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/6048526849/job/16418900113?pr=211 https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/6048526849/job/16418897812?pr=211

Also please install and run pre-commit, you can find instructions here

Checking @bonclay7 , I already have it installed...

[ruchimo]

@bonclay7 - I have fixed the failures detected by pre-commit

[ruchimo]

@bonclay7 I have checked the failures

1. https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/6070146490/job/16486224503?pr=211 --> This is reposting Potential problems on the Modules we are reusing.
2. https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/6070146491/job/16486220400?pr=211 --> This is from the docs, the link would be accesible once the PR is merged.