Fix: collector failing to scrape targets #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonclay7
temporarily deployed
to
Observability Test
GitHub Actions
Inactive
|
24h data shows that this seems much more stable! I think we can go with that fix ping @awsimaya @lewinkedrs |
1 task
lewinkedrs
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Proposal for #171
Suspecting external labels conflicts with scrape config, using attributes processor and
resourcetotelemetryto enforce those labels on all metrics, post scrapingMore
pre-commit run -awith this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes