Fargate New cluster #93

Howlla · 2023-08-22T19:22:02Z

Issue #, if available: 57

Description of changes: New pattern for creating fargate cluster with observability using cloudwatch and containerInsights

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11 · 2023-08-22T21:20:28Z

@Howlla Please fix GitHub Issues.

elamaran11

@Howlla Great work, much needed pattern. Have some tactial and closure comments.

Doc is incomplete.
Please merge from main and fix all conflicts and GH issues.

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md

elamaran11 · 2023-08-23T14:36:52Z

/do-e2e-test single-new-eks-cluster deploy

elamaran11 · 2023-08-23T14:51:34Z

/do-e2e-test single-new-eks-cluster deploy

elamaran11 · 2023-08-23T15:08:12Z

/do-e2e-test single-new-eks-cluster deploy

elamaran11 · 2023-08-23T15:16:16Z

/do-e2e-test single-new-eks-cluster deploy

lib/common/observability-builder.ts

elamaran11 · 2023-08-23T15:39:08Z

/do-e2e-test single-new-eks-cluster destroy

elamaran11 · 2023-08-23T16:01:30Z

/do-e2e-test single-new-eks-cluster destroy

elamaran11 · 2023-08-23T17:46:03Z

/do-e2e-test single-new-eks-cluster destroy

elamaran11 · 2023-08-24T11:30:17Z

@Howlla Can you work on the changes pls. I want to merge this and release this week.

Howlla · 2023-08-28T20:57:23Z

Ready for merge from my side. :)

elamaran11

@Howlla This is AWSome work, great that you got it working. We had some major breaking change with latest merge that happened yesterday.

We are using ObservabilityBuilder from blueprints and removed it from common.
Im not sure why you need specific values to two addons, probably because of Fargate. So you need make those changes as optional props in blueprints ObservabilityBuilder and then use those here, which will happen only after next blueprints release.
Also the pattern needs to be revamped with latest standards of using enable methods, See other patterns for more details.
Also pull from main to push latest code
Please reachout for any questions.

lib/single-new-eks-awsnative-fargate-observability-construct/index.ts

elamaran11 · 2023-09-13T20:00:00Z

Depdendent on this PR. @Howlla thankyou for your work on this. Please alert me once you have it working, i can take a look,

lib/single-new-eks-opensource-observability-pattern/graviton-index.ts

elamaran11

Check the comment

lib/single-new-eks-opensource-observability-pattern/graviton-index.ts

elamaran11

@Howlla Once the current Release upgrade PR goes, in merge from Main to remove all conflicts. Also please update the doc, remove observabilitybuilder and other extra files noted.

lib/common/observability-builder.ts

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md

…y-accelerator

elamaran11

@Howlla Please follow the guidance for the doc and architecture.

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md

elamaran11

@Howlla This is AWSome work. Couple of comments on checkin files not related to this work. And Can we raise the bar in deploying a sample workload like yelb app or something like in Java pattern and show some metrics from the App to CW.?

lib/single-new-eks-awsnative-fargate-observability-construct/index.ts

cdk.json

lib/single-new-eks-awsnative-fargate-observability-construct/index.ts

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md

lib/single-new-eks-awsnative-fargate-observability-construct/index.ts

elamaran11

@Howlla Minor doc feedback. I will run e2e now.

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md

mkdocs.yml

elamaran11 · 2023-10-16T15:10:17Z

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

elamaran11 · 2023-10-16T20:17:32Z

/do-e2e-test single-new-eks-awsnative-fargate-observability destroy

elamaran11

@Howlla Check this

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md

elamaran11 · 2023-10-16T21:39:33Z

@Howlla Destroy is failing. Please make sure destroy works clean in your environment and fix any issues.

elamaran11

LGTM, Nice work

elamaran11 · 2023-10-17T21:23:29Z

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

elamaran11 · 2023-10-17T21:45:28Z

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

elamaran11 · 2023-10-17T23:23:01Z

/do-e2e-test single-new-eks-awsnative-fargate-observability destroy

elamaran11 · 2023-10-18T00:58:49Z

Error is due to CoreDNS failure while destroy. Merging the PR.

Howlla added 8 commits August 15, 2023 15:15

Adding fargate compatibility and new patterns

171444a

create new type to limit parameter into builder

c45b41a

Merge branch 'aws-observability:main' into main

309475d

Prepare for pr

da3e785

remove parameter computeType for existing clusters

ecbae71

lint fix

076b498

remove existing aws fargate code

cdce95a

lint fix

a96a1aa

elamaran11 requested changes Aug 23, 2023

View reviewed changes

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md Show resolved Hide resolved

elamaran11 requested changes Aug 23, 2023

View reviewed changes

lib/common/observability-builder.ts Outdated Show resolved Hide resolved

Howlla added 4 commits August 24, 2023 15:23

Merge branch 'aws-observability:main' into main

b4ab8dd

Added documentation and reset observability builder code

244b64d

Correct addons for fargate and add namespace for opentelemetry

65a89e4

Merge branch 'aws-observability:main' into main

aa6f252

elamaran11 requested changes Aug 29, 2023

View reviewed changes

lib/single-new-eks-awsnative-fargate-observability-construct/index.ts Outdated Show resolved Hide resolved

lib/single-new-eks-awsnative-fargate-observability-construct/index.ts Outdated Show resolved Hide resolved

Howlla added 4 commits August 29, 2023 11:50

Merge remote-tracking branch 'upstream/main'

e86be21

Merge branch 'aws-observability:main' into main

e11a7e9

Explicitly define addons for fargate pattern

37f068d

pass coredns props

ba4451c

Howlla commented Oct 7, 2023

View reviewed changes

lib/single-new-eks-opensource-observability-pattern/graviton-index.ts Outdated Show resolved Hide resolved

elamaran11 requested changes Oct 7, 2023

View reviewed changes

lib/single-new-eks-opensource-observability-pattern/graviton-index.ts Outdated Show resolved Hide resolved

Howlla added 2 commits October 7, 2023 11:20

update version and minor props fix for addons

c368a73

kubeproxy auto instead of explicit

1fd56ca

elamaran11 requested changes Oct 7, 2023

View reviewed changes

Howlla added 3 commits October 8, 2023 00:04

Merge branch 'main' into main

633850b

updated docs

8290fc2

Merge branch 'main' of https://github.com/Howlla/cdk-aws-observabilit…

edc2f92

…y-accelerator

elamaran11 requested changes Oct 8, 2023

View reviewed changes

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md Show resolved Hide resolved

Howlla added 3 commits October 9, 2023 10:57

Merge branch 'aws-observability:main' into main

545fa3b

update image location

dcbddd7

auto coredns version

701ca57

elamaran11 requested changes Oct 9, 2023

View reviewed changes

Howlla added 2 commits October 12, 2023 14:50

Merge branch 'aws-observability:main' into main

cad2ca6

fargate holly monitoring

460b6f7

elamaran11 requested changes Oct 16, 2023

View reviewed changes

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md Outdated Show resolved Hide resolved

mkdocs.yml Outdated Show resolved Hide resolved

updated docs

502acce

elamaran11 requested changes Oct 16, 2023

View reviewed changes

.../single-new-eks-observability-accelerators/single-new-eks-awsnative-fargate-observability.md Outdated Show resolved Hide resolved

Howlla added 3 commits October 16, 2023 14:45

added deployment steps in docs

9af21ca

clean delete except coredns

b778c8c

Cat command for manifest

46b3cd0

elamaran11 approved these changes Oct 17, 2023

View reviewed changes

elamaran11 merged commit 4fdc245 into aws-observability:main Oct 18, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fargate New cluster #93

Fargate New cluster #93

Howlla commented Aug 22, 2023

elamaran11 commented Aug 22, 2023

elamaran11 left a comment

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 24, 2023

Howlla commented Aug 28, 2023

elamaran11 left a comment

elamaran11 commented Sep 13, 2023

elamaran11 left a comment

elamaran11 left a comment

elamaran11 left a comment

elamaran11 left a comment

elamaran11 left a comment

elamaran11 commented Oct 16, 2023

elamaran11 commented Oct 16, 2023

elamaran11 left a comment

elamaran11 commented Oct 16, 2023

elamaran11 left a comment

elamaran11 commented Oct 17, 2023

elamaran11 commented Oct 17, 2023

elamaran11 commented Oct 17, 2023

elamaran11 commented Oct 18, 2023

Fargate New cluster #93

Fargate New cluster #93

Conversation

Howlla commented Aug 22, 2023

elamaran11 commented Aug 22, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023

elamaran11 commented Aug 24, 2023

Howlla commented Aug 28, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 commented Sep 13, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 commented Oct 16, 2023

elamaran11 commented Oct 16, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 commented Oct 16, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 commented Oct 17, 2023

elamaran11 commented Oct 17, 2023

elamaran11 commented Oct 17, 2023

elamaran11 commented Oct 18, 2023