Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Service accounts and Grafana v10 #163

Merged
merged 1 commit into from
May 16, 2024
Merged

Update docs for Service accounts and Grafana v10 #163

merged 1 commit into from
May 16, 2024

Conversation

bonclay7
Copy link
Member

Issue #, if available:

Updated the docs to include MG v10.

1/ I realized that there's a lot of duplication of commands. Maybe worth creating a single pre-requisite page with the same instructions centralized there? That could avoid update issues

2/ the amg-preconfig.sh uses create-workspace-api-key API, and maybe should evolve to use service accounts. This is fine for now, but could be an issue in future MG releases

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bonclay7 bonclay7 requested a review from elamaran11 May 16, 2024 11:22
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit cb5c451 into main May 16, 2024
2 checks passed
@elamaran11 elamaran11 deleted the mg-v10 branch May 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants