Cost monitoring with kubecost and AMP #154
Conversation
There was a problem hiding this comment.
@Howlla @arunvthangaraj Approach looks good but lot of cleanup required on code for tactical and standard alignment. I will provide more feedback once the pattern works.
lib/single-new-eks-cost-monitoring-pattern/grafanaoperatorsecretaddon.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@Howlla Need some changes to this pattern. I have highlighted the changes. We should maek this work with Kubecost free version.
lib/single-new-eks-cost-monitoring-pattern/kubecostserviceaccountsaddon.ts
Show resolved
Hide resolved
|
Please review @elamaran11 |
There was a problem hiding this comment.
@Howlla Very nice work, appreciate all the hardword. Have some comments to work on:
- Merge conflicts, please pull latest code from main and remove unnecessary files from PR.
- Documentation needs to improve and not clearing explaining the purpose.
- Add more screenshots on showing cost mon with Kubecost
- Some unnecessary commented lines
lib/single-new-eks-cost-monitoring-pattern/lambda/lambda_function.py
Outdated
Show resolved
Hide resolved
...e-new-eks-observability-accelerators/single-new-eks-cost-monitoring-ingress-observability.md
Show resolved
Hide resolved
|
Please review ela, made required changes |
There was a problem hiding this comment.
@Howlla Everthing looks great from Pattern perspective. The architecture diagram is from another kubecost pattern and missing AMP, AMG monitoring references. Also please add more screenshots from Kubecost to make it complete. Once these two are done, we can proceed to E2E and merge.
...e-new-eks-observability-accelerators/single-new-eks-cost-monitoring-ingress-observability.md
Show resolved
Hide resolved
|
/do-e2e-test single-new-eks-fargate-opensource-observability deploy |
|
/do-e2e-test single-new-eks-fargate-opensource-observability destroy |
There was a problem hiding this comment.
@Howlla Looks great, just fix the command issue and also fix the GH Action errors. I can run e2e for new pattern.
...e-new-eks-observability-accelerators/single-new-eks-cost-monitoring-ingress-observability.md
Outdated
Show resolved
Hide resolved
|
/do-e2e-test single-new-eks-cost-monitoring deploy single-new-eks-cost-monitoring-observability-accelerator |
|
/do-e2e-test single-new-eks-opensource-observability deploy |
There was a problem hiding this comment.
@Howlla Typo error in folder name its cognito and not congito.
...e-new-eks-observability-accelerators/single-new-eks-cost-monitoring-ingress-observability.md
Outdated
Show resolved
Hide resolved
|
/do-e2e-test single-new-eks-cost-monitoring deploy |
|
|
*Issue #, if available:*#18
Description of changes: Brand new pattern using congito for auth, amp for storage and kubecost for visualization of cost metrics
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.