Inferentia inf1 observability #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
elamaran11
requested changes
Mar 13, 2024
| @@ -50,7 +56,7 @@ export default class SingleNewEksAWSNativeFargateobservabilityConstruct { | |||
| }; | |||
|
|
|||
| const coreDnsAddOnProps : blueprints.CoreDnsAddOnProps = { | |||
| version:"v1.10.1-eksbuild.6", | |||
| versionMap, | |||
There was a problem hiding this comment.
You dont need versionMap. All you have to do is pass auto or version.
There was a problem hiding this comment.
if we set it to auto it will be V1_28 right?
the default mapping is:
KubernetesVersion.V1_28, "v1.10.1-eksbuild.2"
that will be different from v1.10.1-eksbuild.6 selected above, is that ok?
There was a problem hiding this comment.
Just pass the desired version.
| @@ -12,6 +12,12 @@ export default class SingleNewEksAWSNativeFargateobservabilityConstruct { | |||
| const account = process.env.COA_ACCOUNT_ID! || process.env.CDK_DEFAULT_ACCOUNT!; | |||
| const region = process.env.COA_AWS_REGION! || process.env.CDK_DEFAULT_REGION!; | |||
|
|
|||
| const versionMap: Map<eks.KubernetesVersion, string> = new Map([ | |||
| [eks.KubernetesVersion.V1_28, "v1.10.1-eksbuild.6"], | |||
| [eks.KubernetesVersion.V1_27, "v1.10.1-eksbuild.6"], | |||
There was a problem hiding this comment.
VersionMap is not required.
| "aws-sdk": "^2.1455.0", | ||
| "constructs": "^10.3.0", | ||
| "eks-blueprints-cdk-kubeflow-ext": "0.1.9", | ||
| "source-map-support": "^0.5.21" | ||
| }, | ||
| "overrides": { | ||
| "@aws-quickstart/eks-blueprints": "^1.13.1", | ||
| "@aws-quickstart/eks-blueprints": "^1.14.0", | ||
| <<<<<<< HEAD |
| @@ -21,37 +21,41 @@ | |||
| "name": "grafana-dashboards", | |||
| "namespace": "grafana-operator", | |||
| "repository": { | |||
| "repoUrl": "https://github.com/aws-observability/aws-observability-accelerator", | |||
| "repoUrl": "https://github.com/freschri/aws-observability-accelerator", | |||
There was a problem hiding this comment.
Why are we changing this?
| "name": "grafana-dashboards", | ||
| "targetRevision": "main", | ||
| "targetRevision": "neuron-dashboard", |
There was a problem hiding this comment.
Why are we changing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New aws quickstarts version