Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 114 monitor adot collector #132

Conversation

hmuthusamy
Copy link
Contributor

Issue #, if available:
#114
Description of changes:
A Pattern to monitor ADOT Collector health and add ADOT dashboard optionally using cdk.json configurations.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmuthusamy Changes look good, Could you please run the changes with Fargate pattern alone and let us know if it works fine. I will kick e2e.

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

@hmuthusamy
Copy link
Contributor Author

@elamaran11 Added snapshots for Fargate working scenario
Screenshot 2023-11-17 at 4 43 11 PM
Screenshot 2023-11-17 at 4 39 04 PM
Screenshot 2023-11-17 at 4 37 22 PM

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability destroy

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work @hmuthusamy Merging this.

@elamaran11 elamaran11 merged commit c3fcc67 into aws-observability:main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants