Control Plane Logging as a default in all patterns #129
Conversation
…e documentation updates for all patterns
There was a problem hiding this comment.
@5herlocked Nice work on this PR and blueprints PR. Have some tactical and doc comments. Please fix these when you get chance. We can merge this only after blueprints release so we should also factor for changes to package.json later.
docs/patterns/existing-eks-observability-accelerators/existing-eks-apiserver-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-awsnative-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-mixed-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-nginx-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-opensource-observability.md
Outdated
Show resolved
Hide resolved
...s/single-new-eks-observability-accelerators/single-new-eks-nginx-opensource-observability.md
Outdated
Show resolved
Hide resolved
...atterns/single-new-eks-observability-accelerators/single-new-eks-opensource-observability.md
Outdated
Show resolved
Hide resolved
…r all existing deployments, enabling control plane logging remains a user choice.
There was a problem hiding this comment.
@5herlocked Looks great, fix these minor issues. We will block the e2e and merge until we have blueprints release.
docs/patterns/existing-eks-observability-accelerators/existing-eks-apiserver-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-awsnative-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-mixed-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-mixed-observability.md
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-nginx-observability.md
Outdated
Show resolved
Hide resolved
docs/patterns/existing-eks-observability-accelerators/existing-eks-opensource-observability.md
Outdated
Show resolved
Hide resolved
|
Resolved the comments in the docs, ready to GTM after deployment of the upstream changes. |
|
@5herlocked GH Failure needs to be fixed. |
|
Error has nothing to do with my code. |
This is not because of your code but did you pull from main, that could be the reason. I had one PR yesterday and we never had that error. |
|
/do-e2e-test single-new-eks-awsnative-observability deploy |
|
/do-e2e-test single-new-eks-awsnative-observability destroy |
Issue #, if available: #118
Description of changes: Added control plane logging through upstream changes and minor modifications to blueprints.
Included documentation changes + instructions on how to access Control Plane logs in CloudWatch.
Control Plane logging is an in-place change to EKS clusters and should not be a breaking change.
Hard dependency on aws-quickstart/cdk-eks-blueprints@d826223 being packaged and released.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.