Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic ControlPlane Logging to All Patterns #118

Closed
elamaran11 opened this issue Oct 9, 2023 · 5 comments
Closed

Generic ControlPlane Logging to All Patterns #118

elamaran11 opened this issue Oct 9, 2023 · 5 comments
Assignees

Comments

@elamaran11
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
Geeneric ControlPlane Logging to All Patterns

const genericClusterProviderProps: blueprints.GenericClusterProviderProps = {
      clusterName: "test-cluster",
      clusterLogging: [
        ClusterLoggingTypes.API,
        ClusterLoggingTypes.CONTROLLER_MANAGER,
        ClusterLoggingTypes.AUTHENTICATOR,
        ClusterLoggingTypes.SCHEDULER,
        ClusterLoggingTypes.AUDIT,
      ],
      managedNodeGroups: [
        {
          id: `managed-group-eks-optimized-${InstanceSize.XLARGE}`,
          instanceTypes: [InstanceType.of(InstanceClass.M6A, InstanceSize.XLARGE)],
          nodeGroupCapacityType: CapacityType.ON_DEMAND,
          amiType: NodegroupAmiType.AL2_X86_64,
          maxSize: 25,
          minSize: 4,
          forceUpdate: true,
        },
      ],
    };

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@elamaran11 elamaran11 changed the title Geeneric ControlPlane Logging to All Patterns Generic ControlPlane Logging to All Patterns Oct 20, 2023
@elamaran11
Copy link
Contributor Author

Shardul is working on this.

@5herlocked
Copy link
Contributor

I'm working on it confirmed

@5herlocked
Copy link
Contributor

This requires a change in: https://github.com/aws-quickstart/cdk-eks-blueprints/blob/main/lib/builders/observability-builder.ts

Will open a PR there and link it here.

@5herlocked
Copy link
Contributor

@elamaran11
Copy link
Contributor Author

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants