Skip to content

Commit

Permalink
addressing pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
freschri committed Mar 14, 2024
1 parent 2dd3f67 commit ad840b8
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 1,755 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ node_modules
# CDK asset staging directory
.cdk.staging
cdk.out
cdk.json
dist
*.swp
cdk.context.json
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,7 @@ aws ec2 describe-instance-type-offerings \
--region us-east-2
```

8. For the `neuron-monitor` DaemonSet, you can either use the image already referenced into the manifest, or build your own using the Dockerfile at location `cdk-aws-observability-accelerator/lib/common/resources/neuron/neuron-monitor.dockerfile`, [push it to an ECR repository](https://docs.aws.amazon.com/AmazonECR/latest/userguide/docker-push-ecr-image.html) of your choice and update the image URL in the manifest at location `cdk-aws-observability-accelerator/lib/single-new-eks-opensource-observability-pattern/neuron/neuron-monitor.yaml`.

9. Once all pre-requisites are set you are ready to deploy the pipeline. Run the following command from the root of this repository to deploy the pipeline stack:
8. Once all pre-requisites are set you are ready to deploy the pipeline. Run the following command from the root of this repository to deploy the pipeline stack:

```bash
make build
Expand Down Expand Up @@ -234,7 +232,7 @@ Login to your Amazon Managed Grafana workspace and navigate to the Dashboards pa
To actually see some interesting metrics on the Grafana dashboard, we will apply the following manifest:

```bash
kubectl apply -f ./lib/common/resources/neuron/pytorch-inference-resnet50.yml
curl https://raw.githubusercontent.com/aws-observability/aws-observability-accelerator/main/artifacts/k8s-deployment-manifest-templates/neuron/pytorch-inference-resnet50.yml | kubectl apply -f -
```

This is just a sample workload that compiles the [torchvision ResNet50 model](https://docs.aws.amazon.com/dlami/latest/devguide/tutorial-inferentia-pytorch-neuron.html) and runs repetitive inference in a loop to generate telemetry data.
Expand Down
33 changes: 0 additions & 33 deletions lib/common/resources/neuron/neuron-monitor.dockerfile

This file was deleted.

96 changes: 0 additions & 96 deletions lib/common/resources/neuron/pytorch-inference-resnet50.yml

This file was deleted.

Loading

0 comments on commit ad840b8

Please sign in to comment.