Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates README with useful information after the removal of the logging templates #90

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

romogo17
Copy link
Contributor

Description:

  • Updates both the repo README and the Helm Chart README with information useful for users who might land in this repository looking for a logging integration with CloudWatch.
  • Links to aws-for-fluent-bit Helm Chart which provides an similar integration from the one removed in Remove logging templates from helm chart #82
  • Removes a few trailing spaces in a couple other lines

Link to tracking Issue: #88

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…rnatives available after the logging templates were removed from this repo
@romogo17 romogo17 requested a review from a team as a code owner February 22, 2023 21:05
Copy link
Member

@mhausenblas mhausenblas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this @romogo17 and LGTM overall.

README.md Outdated Show resolved Hide resolved
@romogo17
Copy link
Contributor Author

Updated PR @mhausenblas

@bryan-aguilar bryan-aguilar merged commit bd56c4c into aws-observability:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants