feat: Adds new dashboards for KCM and KSH metrics 1.0 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiskyAdventure
changed the title
elamaran11
reviewed
Oct 29, 2024
There was a problem hiding this comment.
@RiskyAdventure Thanks for the PR, have following feedback:
- Please follow the naming convention for your new dashboards in the repo.
- What are we going to do with these new dashboards. If you need these dashboards to be created CDK or terraform accelerator. You need to add these to dashboards via Grafana operator.
- Also Collector config for the data to flow to these dashboards should be added to CDK EKS and Terraform EKS Accelerator to have these working in our accelerators otherwise these are going to empty dashboards.
please share screenshots of dashboards with the PR once you are done testing.
|
Ela, sorry for improper push. Feedback has been addressed. @elamaran11 |
elamaran11
reviewed
Nov 19, 2024
There was a problem hiding this comment.
@RiskyAdventure This looks great. Let me ask Ashok to run this with terraform accelerator before i can merge.
|
KSH Dashboard Sample |
RiskyAdventure
force-pushed
the
cp-metrics
branch
from
aa878c2 to
5eee7bf
Compare
elamaran11
reviewed
Nov 20, 2024
There was a problem hiding this comment.
@RiskyAdventure Can you remove all the 5 .DS_Store files. rest looks good. Also the screenshots of the data on Grafana boards look great.
RiskyAdventure
force-pushed
the
cp-metrics
branch
from
ac211c6 to
253c66b
Compare
RiskyAdventure
force-pushed
the
cp-metrics
branch
from
7a1324d to
bd75e6b
Compare
|
Tested the dashboards using the terraform blueprint and attached the screenshots. KubeScheduler Dashboard KubeControllerManager Dashboard |
elamaran11
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Created new KCM and KSH dashboards for new control plane metrics.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.