sample applications and grafana-operator argocd app for multi-account CDK Observability accelerator #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
previously approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM. @bonclay7 Can you review this. We are adding new setup of artifacts to support multi account pattern with Argo CD - new flavour which our customers ask
|
@iamprakkie Please fix the warnings. |
|
@elamaran11 All warnings fixed |
elamaran11
requested changes
Oct 3, 2023
There was a problem hiding this comment.
@iamprakkie Looks good, have below comments.
- See too many files checkin, can you check in files only related to the multi account/region pattern?
- Remove unnecessary stuff like teams, karpenter. Lets keep the PR slim as far as possible
- Can we group all Argo artifacts under Argo folder?
…cd-apps removed teams not in use with multi-account pattern (removed team-kirk, team-data, team-danger, team-scan, team-platform, team-burnham and team-riker). retained team-geordie and team-carmen moved grafana-operator-app to artifacts/argocd-apps removed samples-apps/envs/dev and samples-apps/envs/test. Retaining only samples-apps/envs/prod
|
incorporated review comments
|
elamaran11
requested changes
Oct 4, 2023
artifacts/argocd-apps/sample-apps/envs/prod/templates/team-carmen.yaml
Outdated
Show resolved
Hide resolved
artifacts/argocd-apps/grafana-operator-chart/templates/amg_grafana-amp-datasource.yaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new contents to artifacts:
grafana-operatorresources like datasources, dashboards and grafana identity.