Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update subnet documentation #46

Merged
merged 1 commit into from
May 20, 2022
Merged

update subnet documentation #46

merged 1 commit into from
May 20, 2022

Conversation

drewmullen
Copy link
Contributor

implementing based on aws-ia/standards-terraform#26

tbulding
tbulding approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@tbulding tbulding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drewmullen drewmullen requested a review from tlindsay42 May 20, 2022 20:14
@drewmullen drewmullen merged commit 2000bb1 into main May 20, 2022
@drewmullen drewmullen deleted the update-subnets-docs branch May 20, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troy-ameigh troy-ameigh troy-ameigh approved these changes

@tbulding tbulding tbulding approved these changes

@tonynv tonynv Awaiting requested review from tonynv tonynv is a code owner

@andrew-glenn andrew-glenn Awaiting requested review from andrew-glenn andrew-glenn is a code owner

@tlindsay42 tlindsay42 Awaiting requested review from tlindsay42 tlindsay42 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewmullen @tbulding @troy-ameigh