Rewrite of vpc module + awscc resources #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewmullen
requested review from
tonynv,
andrew-glenn and
tbulding
as code owners
drewmullen
changed the title
tbulding
reviewed
Mar 23, 2022
tlindsay42
reviewed
Mar 23, 2022
tlindsay42
reviewed
Mar 23, 2022
tlindsay42
requested changes
Mar 23, 2022
tlindsay42
previously approved these changes
Apr 5, 2022
tbulding
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a complete rewrite of the VPC module. Inputs and outputs are expected to change and thus cause a breaking change release. We use awscc resources where possible
Subnets in a VPC are defined in the
subnetsmap variable. Public / Private are currently only allowed. Transit Gateway subnets are a fast follow to this PRYou can calculate the CIDRs for your subnets by passing a
netmaskargument. This is especially helpful when using ipam to derive your VPC CIDR.Examples and tests are provided
Follow ups: