Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed bug on ipv6_subnets_cwan_routed local variable #112

Merged
merged 3 commits into from
Jun 12, 2023
Merged

fix: fixed bug on ipv6_subnets_cwan_routed local variable #112

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a8ba1a
fix: fixed bug on ipv6_subnets_cwan_routed local variable that referr…
darrenhorwitz1 May 17, 2023
87967b6
fix: reverted terraform module's source and version in cloudwan example
darrenhorwitz1 May 24, 2023
801fa4a
fix: reverted changes on for ipv6 support cwan example
darrenhorwitz1 Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ locals {
private_subnet_key_names_cwan_routes = [for subnet in local.private_per_az : subnet if contains(local.subnets_cwan_routed, split("/", subnet)[0])]

# support variables for core_network_ipv6_routes
ipv6_subnets_cwan_routed = keys(var.core_network_routes)
ipv6_subnets_cwan_routed = keys(var.core_network_ipv6_routes)
ipv6_private_subnet_keys_names_cwan_routes = [for subnet in local.private_per_az : subnet if contains(local.ipv6_subnets_cwan_routed, split("/", subnet)[0])]

# support variables for core_network subnets
Expand Down
20 changes: 9 additions & 11 deletions examples/cloud_wan/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@

# VPC module (North Virginia)
module "nvirginia_vpc" {
source = "aws-ia/vpc/aws"
version = ">= 4.2.0"
source = "aws-ia/vpc/aws"
version = ">= 4.2.0"

providers = { aws = aws.awsnvirginia }

name = "nvirginia-vpc"
Expand Down Expand Up @@ -42,13 +43,14 @@ module "nvirginia_vpc" {

# VPC module (Ireland)
module "ireland_vpc" {
source = "aws-ia/vpc/aws"
version = ">= 4.2.0"
tlindsay42 marked this conversation as resolved.
Show resolved Hide resolved
source = "aws-ia/vpc/aws"
version = ">= 4.2.0"

providers = { aws = aws.awsireland }

name = "ireland-vpc"
cidr_block = "10.0.1.0/24"
vpc_assign_generated_ipv6_cidr_block = true
vpc_assign_generated_ipv6_cidr_block = false
az_count = 2

core_network = {
Expand All @@ -58,18 +60,14 @@ module "ireland_vpc" {
core_network_routes = {
workload = "0.0.0.0/0"
}
core_network_ipv6_routes = {
workload = "::/0"
}

subnets = {
workload = {
netmask = 28
assign_ipv6_cidr = true
assign_ipv6_cidr = false
}
core_network = {
netmask = 28
assign_ipv6_cidr = true
assign_ipv6_cidr = false
require_acceptance = false

tags = {
Expand Down