Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to publish the module #13

Merged
merged 3 commits into from
May 2, 2023
Merged

bump version to publish the module #13

merged 3 commits into from
May 2, 2023

Conversation

wellsiau-aws
Copy link
Collaborator

No description provided.

@aws-ia-automator-gamma
Copy link

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.
If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are
not ready to publish yet, we recommend you close this PR and develop against a different branch.
Once you are ready to publish you can open a PR from that branch to main.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS PoC who is assisting you with this project.

@wellsiau-aws
Copy link
Collaborator Author

/confirm-publication

Copy link

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review hs been requested from required contributors, once they have approved I will remove my request for changes. When this PR is merged your project will be published

@wellsiau-aws wellsiau-aws self-assigned this Apr 30, 2023
@wellsiau-aws wellsiau-aws requested review from tonynv and tbulding April 30, 2023 22:55
tonynv
tonynv previously approved these changes Apr 30, 2023
@wellsiau-aws wellsiau-aws removed the request for review from tbulding May 1, 2023 00:30
@wellsiau-aws
Copy link
Collaborator Author

/do-e2e2-tests

@tonynv
Copy link
Contributor

tonynv commented May 1, 2023

/do-e2e-tests

@aws-ia-automator-gamma
Copy link

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link

e2e test in progress

Copy link

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator Author

Not sure why it failed, my local e2e test works just fine:


Saved the plan to: tf.plan

To perform exactly these actions, run the following command to apply:
    terraform apply "tf.plan"
2023-05-02 00:46:36,083 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudfront/aws:3.2.1 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,086 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/acm/aws:~>4.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:~>3.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/lambda/aws:~>4.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,088 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/records:~>2.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,090 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:None (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,091 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:None (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,091 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/sqs/aws:~>3.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,092 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:~>3.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,093 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:~>3.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,094 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:~>1.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,095 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:~>4.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,095 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudfront/aws:None (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,096 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/lambda/aws:~>2.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,097 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/sns/aws:~>3.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,098 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:~>2.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,099 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/lambda/aws:~>3.0 (for external modules, the --download-external-modules flag is required)
2023-05-02 00:46:36,100 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:None (for external modules, the --download-external-modules flag is required)
terraform_plan scan results:

Passed checks: 85, Failed checks: 0, Skipped checks: 16

@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-gamma
Copy link

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link

e2e test in progress

Copy link

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator Author

I learned that the check is failing because the recent update on checkov test CKV_AWS_338

@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-gamma
Copy link

End to end test has been scheduled

@aws-ia-automator-gamma
Copy link

e2e test in progress

Copy link

@aws-ia-automator-gamma aws-ia-automator-gamma bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests completed successfully

@wellsiau-aws wellsiau-aws requested a review from tonynv May 2, 2023 02:47
@tbulding tbulding merged commit 944da8f into aws-ia:main May 2, 2023
@wellsiau-aws wellsiau-aws deleted the ws-abp-setup branch May 3, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants