Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add oac with cloudfront, edge lambda, updates to request/callback #118

Merged
merged 28 commits into from
Dec 18, 2024

Conversation

quixoticmonk
Copy link
Collaborator

@quixoticmonk quixoticmonk commented Dec 17, 2024

Description

The PR updates

  • the authentication mechanism on the lambda url to AWS_IAM
  • Updated CloudFront to use the lambda updates
  • Added lambda edge function inject the header x-amz-content-sha256
  • Updated references of Terraform Cloud to HCP Terraform.
  • Added a tags variable to all feasible resources
  • Lambda version bumped to 3.11
  • sleep reference added for lambda@Edge deletion and Cloudfront resource.
  • fulfillment logic fix for No resource changes
  • aws/tfe provider version updates
  • minimum protocol version to TLSV1 to remove drift as choosing default CloudFront certificate sets the value to TLSV1

Scenarios tested

  • Right workspace prefix
    • incorrect IAM permissions : Successfully fails with the results from the analyzer
    • correct permissions : Successful with no results
    • No changes : Successful
  • Incorrect workspace : Fails as expected with the message to check the runtasks association.

Resolves #116
Closes #117
Resolves #115
Resolves #113
Resolves #119
Resolves #120

@quixoticmonk quixoticmonk marked this pull request as ready for review December 18, 2024 00:18
@wellsiau-aws wellsiau-aws self-assigned this Dec 18, 2024
@wellsiau-aws wellsiau-aws added bug Something isn't working enhancement New feature or request labels Dec 18, 2024
@wellsiau-aws
Copy link
Collaborator

Resolving #119 will require breaking change for existing customer, since we moved the state function log name space from /aws/state/ to /aws/vendedlogs/states/

@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator

I am migrating the test account for functional test and forgot to populate the SSM params.

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@quixoticmonk
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator

error creating WAF log, might be relevant to this

@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@wellsiau-aws wellsiau-aws merged commit cad781c into main Dec 18, 2024
3 checks passed
@wellsiau-aws wellsiau-aws deleted the fix/lambda_auth_cfront branch December 18, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants