Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aurora Global Database Setup and other updates #2

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Aurora Global Database Setup and other updates #2

merged 4 commits into from
Jul 20, 2021

Conversation

catcharbind
Copy link
Contributor

  • Aurora Global database setup across 2 AWS regions
  • Setup for both Aurora PostgreSQL and MySQL
  • Parameter groups
  • Enhanced Monitoring

tonynv
tonynv reviewed Jul 9, 2021
View reviewed changes
deploy/main.tf Outdated Show resolved Hide resolved
tonynv
tonynv reviewed Jul 9, 2021
View reviewed changes
deploy/main.tf Outdated Show resolved Hide resolved
tonynv
tonynv requested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@tonynv tonynv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not reference aws-quickstart, everything should be pointed to aws-ia

setup_workspace/workspace.tf Outdated Show resolved Hide resolved
deploy/main.tf Outdated Show resolved Hide resolved
@catcharbind catcharbind requested a review from tonynv July 9, 2021 00:28
tonynv
tonynv reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@tonynv tonynv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default it create the global db. I suggest we create two entry points in the deploy folder deploy/standard_db and deploy/global_db the current main should move into that folder. I have also updated the vpc module with create_vpc. With option we could potentialy keep a single entry point under deploy

@tonynv
Copy link
Contributor

tonynv commented Jul 9, 2021 •
edited
Loading

Resource aurora.aws_kms_key.kms_p and aurora.aws_kms_key.kms_s has lifecycle.prevent_destroy set. This prevent clean deletes

@catcharbind
updated setup_globaldb and storage_encrypted to false by default. Upd…
14fd04e 
…ated VPC module version to create vpc conditionally.
@catcharbind
Copy link
Contributor Author

Updated setup_globaldb and storage_encrypted to false by default. Updated VPC module version to create vpc conditionally.
KMS keys need to be retained for any encrypted Aurora snapshots to be retained.

@catcharbind catcharbind requested a review from tonynv July 10, 2021 04:58
@tonynv tonynv merged commit 6caa6b9 into aws-ia:main Jul 20, 2021
tonynv added a commit that referenced this pull request Aug 17, 2021
@tonynv
Merge pull request #4 from catcharbind/main
9ca2996 
Various Updates #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonynv tonynv tonynv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catcharbind @tonynv