Adding ability to add additional principal to trusted policy #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have tested this change and works in production for us. We would like to see this get merged into the main branch 🙏🏽 |
Chili-Man
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the ability to specify a list of additional AWS principal ARNs in the IAM policy for MWAA executor role (Amazon Managed Workflows for Apache Airflow). A new variable additional_principal_arns has been added to allow the inclusion of extra principal ARNs as needed. Resolves #55
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes