Add instance access control attributes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cases and confirm if any other changes are needed.
…d to update the header file and the rest of the readme file.
…se is failing - we should really look at a better way to do these tests.
…is appears to be the standard.
|
re-ran pre-commit and manually created the header.md file |
…g with the way the resource should be defined.
|
/do-e2e-tests |
|
Checks must all be completed successfully before end to end testing can be run. |
…ub.com/dtappert/terraform-aws-iam-identity-center into add-instance-access-control-attributes
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
E2E tests in progress |
![aws-ia-automator-prod[bot]](https://avatars.githubusercontent.com/u/149281641?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding basic support for terraform instance access control attributes.
Open to doing a design review or getting feedback on whether we want/need to do any more robust integration testing.
I also noticed that we have a lot of tests that fail in a new account unless you go through and read the comments that tell you to create certain resources in the target AWS account (added a few missing comments/hints, too).