Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add output for sso groups ids #31

Merged
merged 1 commit into from
May 9, 2024

Conversation

matiasbertani
Copy link
Contributor

To be able to reference them outside the module.

@matiasbertani
Copy link
Contributor Author

@novekm / @tbulding Could you give this a look. I think It is a very useful feature

@matiasbertani matiasbertani force-pushed the add-output-for-groups_ids branch from a709888 to 88cd221 Compare May 8, 2024 20:52
@novekm
Copy link
Collaborator

novekm commented May 8, 2024

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot previously approved these changes May 8, 2024
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@novekm
Copy link
Collaborator

novekm commented May 8, 2024

Hi @matiasbertani, thanks for your contribution! PR looks good and end-to-end test completed successfully. Can you please update the VERSION file in your PR to be v0.0.2? then I will approve/merge

To be able to reference them outside the module
@matiasbertani
Copy link
Contributor Author

Can you please update the VERSION file in your PR to be v0.0.2?

@novekm Done!

Copy link
Collaborator

@novekm novekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@novekm
Copy link
Collaborator

novekm commented May 9, 2024

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@novekm novekm merged commit 7bd806f into aws-ia:main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants