AWS PCA Issuer #359
AWS PCA Issuer #359
Conversation
anshrma
requested review from
askulkarni2,
kcoleman731 and
vara-bonthu
as code owners
There was a problem hiding this comment.
Thanks @anshrma for the PR. This will be a great add-on. Would you mind creating a pattern to show with example on how to use this Add-on?
Update docs page as well here https://github.com/aws-samples/aws-eks-accelerator-for-terraform/tree/main/docs/add-ons
There was a problem hiding this comment.
@anshrma thanks so much for the PR. Its looking good, some minor changes are needed as per our convention. Also please address @vara-bonthu's comments as well.
|
@vara-bonthu / @askulkarni2 - Thanks for review. Addressed all the feedback with updated code. Pls let me know, if anything else. Once this gets merged, next i will send another PR for a partner using these add-ons |
There was a problem hiding this comment.
@anshrma some nitpicky comments, but PR is looking really good.
One question on whether we should remove all IRSA for cert-manager. I don't have enough knowledge there, will wait on a few confirmations there from @vara-bonthu, @kcaws.
|
@askulkarni2 / @vara-bonthu - Addressed all the review feedback. |
There was a problem hiding this comment.
Good work on this PR @anshrma.
Please see comments and it requires few changes.
|
Yes, I have provided the IRSA policies above |
|
@anshrma have you had a chance to review @vara-bonthu's feedback? |
Hi @askulkarni2 - Will pick this up tomorrow. Back today after PTO. Thanks |
|
Thanks for all the feedback @vara-bonthu . Done with all the changes suggested. |
|
hi @vara-bonthu / @askulkarni2 - Pls review this when you get a chance. All the feedback comments have been addressed. |
|
@anshrma I am running our e2e tests and I see some FYI.. I am also running terratest here https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/6201005974?check_suite_focus=true. |
hi @askulkarni2 - fixed the terraform fmt errors |
…n/test/util/types/node-18.14.6 Bump @types/node from 18.11.18 to 18.14.6 in /test/util
What does this PR do?
This PR adds a new module for helm installation of AWS PCA issuer, which is an extension of cert-manager for certificate management using AWS ACM.
Motivation
Working with a large Partner in API Gateway space (another PR coming next), which requires this
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes