-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of depends_on for accelerator module, remove fargate_profiles from base example #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this change is to avoid Error: Invalid for_each argument
issue with module level dependency using aws.vpc.
PR looks good to me. Few changes needs to be done. Thanks 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
fix: Update sealed secrets deployment to only reference secrets entries
What does this PR do?
depends_on
foreks-cluster-with-new-vpc
example between accelerator module and vpcMotivation
Cleaner TF destroy, avoid scenarios where VPC resources are deleted before EKS managed node groups does which leads to exceptions and the need of multiple destroy retries.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes