Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-managed node group example testing and updates #324

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

naris-silpakit
Copy link
Contributor

What does this PR do?

Updates the example so it only creates 3 public and 3 private subnets as described in the readme. This PR also serves to validate that this example still works. This PR also includes a small whitespace fix that was caught by pre-commit.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Followed the readme deployment and testing steps to validate that it works as expected.

…s as described in the readme; formatting caught by pre-commit
@naris-silpakit
Copy link
Contributor Author

Whoops, I forgot to make some of the other updates for this example. Closing for now and will open a new PR once I fix this.

@naris-silpakit
Copy link
Contributor Author

Double-checked that everything was correct - PR ready for review.

@naris-silpakit naris-silpakit reopened this Mar 7, 2022
…a step for verifying the autoscaling group in the readme
Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcoleman731 kcoleman731 merged commit b2668ff into main Mar 8, 2022
@vara-bonthu vara-bonthu deleted the feature/update-self-managed-nodegroup-example branch March 10, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants