Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor kubernetes-dashboard for helm-addon #311

Merged
merged 2 commits into from
Mar 4, 2022
Merged

refactor kubernetes-dashboard for helm-addon #311

merged 2 commits into from
Mar 4, 2022

Conversation

askulkarni2
Copy link
Contributor

…on_context

What does this PR do?

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 changed the title remove cluster-id and tags from irsa_config as its now passed via add… refactor kubernetes-dashboard for helm-addon Mar 4, 2022
vara-bonthu
vara-bonthu approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . Please check that the PR test is failing

@kcoleman731
Copy link
Contributor

Checks failing

@askulkarni2
Copy link
Contributor Author

Checks failing

Should be good now.

@vara-bonthu vara-bonthu merged commit 2d066dc into main Mar 4, 2022
@vara-bonthu vara-bonthu deleted the refactor/kubernetes-dashboard branch March 4, 2022 18:42
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
@svennam92
Merge pull request aws-ia#311 from aws-samples/add-indexing
a302869 
enable indexing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcoleman731 kcoleman731 kcoleman731 approved these changes

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askulkarni2 @kcoleman731 @vara-bonthu