Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s_taints documentation and taints fixes #289

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

naris-silpakit
Copy link
Contributor

What does this PR do?

  • Adds examples for k8_taints in the managed-node-group documentation files.
  • Removes k8s_taints from examples that passed them into self-managed node groups as EKS only supports taints through managed node groups.
  • Removes k8_taints local from the aws-eks-fargate-profile module locals.tf for the same reason as above, and it wasn't being used.

Motivation

Addressing a documentation request for k8s_taints for managed node groups. Thanks for reporting this schwichti!

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add support for self-managed via kubelet args.

@naris-silpakit
Copy link
Contributor Author

we should add support for self-managed via kubelet args.

Hoping to keep the changes minor for this PR as it just clarifies the current functionality. I can look into adding taint support for self-managed node groups via the kubelet args as a separate new feature PR.

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcoleman731 kcoleman731 merged commit 8a29e2c into main Feb 26, 2022
@askulkarni2 askulkarni2 deleted the fix/k8s-taint-updates branch February 28, 2022 19:22
@vara-bonthu
Copy link
Contributor

Closing the issue since the PR is merged now.

alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants