Remove hardcoded namespace values in argocd

[naris-silpakit]

What does this PR do?

Removes hardcoded namespace values in the argocd kubernetes addon module. Those entries now reference the argocd helm config.

Motivation

Addressing: #236

Thanks sarasensible for reporting this!

More

• Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
• Yes, I have added a new example under examples to support my PR
• Yes, I have created another PR for add-ons under add-ons repo (if applicable)
• Yes, I have updated the docs for this feature
• Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

• E2E Test successfully complete before merge?

Additional Notes

Testing notes:

• created test directory and filled main.tf file with vpc, eks cluster with argocd addon enabled
• ran terraform apply -auto-approve and checked that deployment completes
• verified login page to argocd management console loaded with kubectl port-forwarding: kubectl port-forward svc/argo-cd-argocd-server -n argocd 8080:443
• added non-default argocd namespace to kubernetes addon module and reapplied template

  argocd_helm_config = {
    namespace = "argocd-test"
  }

• verified new namespace and that argocd login page loads with kubectl port-fowarding using new namespace

[vara-bonthu]

LGTM! Thanks for fixing this @naris-silpakit 👍🏼

[kcoleman731]

one comment for you.