-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus helm chart to 15.3.0 #260
Conversation
… in Prometheus readme to latest; update Prometheus helm chart version to 15.3.0 in documentation example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One change required
@@ -3,7 +3,7 @@ locals { | |||
name = "prometheus" | |||
chart = "prometheus" | |||
repository = "https://prometheus-community.github.io/helm-charts" | |||
version = "14.6.0" | |||
version = "15.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naris-silpakit Could you please find the all the occurrences of the Prometheus version and replace it? Some of the examples are also using the older version of Prometheus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! I'll do that and push an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naris-silpakit please mark this as resolved once you have addressed @vara-bonthu's comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, waiting for comment to be addressed.
@@ -3,7 +3,7 @@ locals { | |||
name = "prometheus" | |||
chart = "prometheus" | |||
repository = "https://prometheus-community.github.io/helm-charts" | |||
version = "14.6.0" | |||
version = "15.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naris-silpakit please mark this as resolved once you have addressed @vara-bonthu's comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…erraform/modules/cluster/terraform-aws-modules/rds/aws-5.2.3 Bump terraform-aws-modules/rds/aws from 5.2.1 to 5.2.3 in /terraform/modules/cluster
What does this PR do?
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes
Testing notes:
terraform apply -auto-approve
and checked that deployment completesprometheus
namespacekubectl port-forward $(kubectl get pods --namespace=prometheus --selector='component=server' --output=name) 8080:9090 -n prometheus
to verify it loads