Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform plan removed from e2e test workflow #253

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Feb 13, 2022

What does this PR do?

  • This variant of the apply command implicitly creates a new plan and then immediately applies it. The -auto-approve option tells Terraform not to require interactive approval of the plan before applying it.

Motivation

  • This will reduce the E2E tests time up to 7 mins.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu self-assigned this Feb 13, 2022
@vara-bonthu vara-bonthu added the enhancement New feature or request label Feb 13, 2022
@kcoleman731 kcoleman731 merged commit 4c479c0 into main Feb 15, 2022
@vara-bonthu vara-bonthu deleted the e2e-tests branch February 21, 2022 09:43
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
…n/test/util/sinon-15.0.1

Bump sinon from 15.0.0 to 15.0.1 in /test/util
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants