-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/208 windows resize volume #231
Conversation
…s-samples/aws-eks-accelerator-for-terraform into fix/208-windows-resize-volume
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this PR @ricardosouzamorais ! I left few minor comments
I think we need to check few things before merging
-
E2E test with Windows and Linux nodes using Self managed with Launch Templates
-
Ensure TF Destroy works without any issues. This is to ensure the IAM role dependency on launch templates
I will run some tests over the weekend with your PR and then we can merge it
@vara-bonthu, I have executed terraform destroy in all scenarios:
I found no issues with that. Regarding the E2E, how should I proceed? Btw, I solved your comments, could you please re-check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's wait for another Approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n/test/util/types/node-18.11.10 Bump @types/node from 18.11.9 to 18.11.10 in /test/util
What does this PR do?
aws-eks-self-managed-node-groups
module uselaunch-templates
moduleMotivation
Attend the need from the community of specifying a volume size greater than the default, for Linux or Windows self managed worked nodes.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes
Windows
Input used
Linux
Input used