Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updating ecr pull though cache pattern #1975

Merged
merged 2 commits into from
Jul 11, 2024
Merged

fix: Updating ecr pull though cache pattern #1975

merged 2 commits into from
Jul 11, 2024
+68 −38

Conversation

candonov
Copy link
Contributor

Description

  • switch the ecr.tf resources to module.
  • create docker secret with Terraform.
  • add clean up instructions

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@candonov candonov requested a review from a team as a code owner July 11, 2024 14:40
@candonov candonov changed the title feat: updating ecr pull though cache pattern Feat: updating ecr pull though cache pattern Jul 11, 2024
@candonov candonov changed the title Feat: updating ecr pull though cache pattern fix: updating ecr pull though cache pattern Jul 11, 2024
@candonov candonov changed the title fix: updating ecr pull though cache pattern fix: Updating ecr pull though cache pattern Jul 11, 2024
askulkarni2
askulkarni2 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@askulkarni2 askulkarni2 merged commit 298317b into aws-ia:main Jul 11, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ecr pull through cache pattern
2 participants
@candonov @askulkarni2