Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update EFA pattern name for discoverability; add info on whats provided and render code of significance in doc site #1939

Merged
merged 1 commit into from
May 3, 2024

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Update EFA pattern name for discoverability; its less about EFA which is an implementation detail of multi-node GPUs
  • Add info on whats provided in the pattern
  • Render code of significance in doc site

Motivation and Context

  • Usability feedback, a following PR will add a pattern for ML capacity blocks since this is a different approach that has been coming up with questions on how to implement

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

image

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ats provided and render code of significance in doc site
@bryantbiggs bryantbiggs requested a review from a team as a code owner May 3, 2024 18:36
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@askulkarni2 askulkarni2 merged commit 9510cec into main May 3, 2024
5 checks passed
@askulkarni2 askulkarni2 deleted the chore/update-odcr branch May 3, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants