Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Copy Kubecost assets to generated site directory, update formating for mkdocs rendering# Description #1923

Merged
merged 2 commits into from
Apr 24, 2024
Merged

fix: Copy Kubecost assets to generated site directory, update formating for mkdocs rendering# Description #1923

merged 2 commits into from
Apr 24, 2024

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Copy Kubecost assets to generated site directory, update formating for mkdocs rendering# Description
  • Remove redundant AWS SSO mkdocs link - theres only one pattern and it uses CAM

Motivation and Context

  • Fixes and thangs

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

⚠️ Before

image

⚠️ After

image

@bryantbiggs bryantbiggs requested a review from a team as a code owner April 18, 2024 19:44
candonov
candonov approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you 🙏

@candonov candonov merged commit 835a4d1 into main Apr 24, 2024
4 checks passed
@candonov candonov deleted the fix/links branch April 24, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candonov candonov candonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @candonov