refactor: Replaced aws-auth ConfigMap entries with access entries #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchintal
changed the title
vchintal
changed the title
vara-bonthu
reviewed
Aug 29, 2024
| resource "aws_eks_access_entry" "karpenter_node_access_entry" { | ||
| cluster_name = module.eks.cluster_name | ||
| principal_arn = module.eks_blueprints_addons.karpenter.node_iam_role_arn | ||
| kubernetes_groups = [] |
There was a problem hiding this comment.
This line is causing an issue when you try to re-apply terraform
aws_eks_access_entry.karpenter_node_access_entry: Modifying... [id=<Karpnter-iam-role-arn>]
╷
│ Error: updating EKS Access Entry (<Karpnter-iam-role-arn>): operation error EKS: UpdateAccessEntry, https response error StatusCode: 400, RequestID: e55f3b9f-b1e0-4c30-bfc8-a1a86b8f024e, InvalidParameterException: The username must not begin with system:
│
│ with aws_eks_access_entry.karpenter_node_access_entry,
│ on addons.tf line 230, in resource "aws_eks_access_entry" "karpenter_node_access_entry":
│ 230: resource "aws_eks_access_entry" "karpenter_node_access_entry" {
Fix is to remove the line
kubernetes_groups = [] from this resource
There was a problem hiding this comment.
Yes, the line should not have been there. @vara-bonthu Do you want to send a PR or want me to do it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
aws-authentries with access entriesHow was this change tested?
pre-commit run -awith this PR