feat: Update gitops multi-cluster pattern to use the new eks pod identity and CAM #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csantanapr
changed the title
csantanapr
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Great job @satishbpatil for your first contributions 🎉
Just a couple minor changes requested 🙏
…dded variable for authentication_mode, updated version number for EKS modules to x.y
csantanapr
requested changes
Apr 19, 2024
There was a problem hiding this comment.
changes look good, but missed one update
On this line https://github.com/satishbpatil/terraform-aws-eks-blueprints/blob/update/gitops-podidentity/issue1916/patterns/gitops/multi-cluster-hub-spoke-argocd/spokes/main.tf#L258
Update to use the local variable
authentication_mode = local.authentication_mode
csantanapr
requested changes
Apr 19, 2024
|
Thank you @satishbpatil I tested the pattern and is working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves from IRSA and pod identity
Motivation and Context
How was this change tested?
Created hub and spoke to validate pod identity. Hub can connect to spoke. Hub was able to install load balancer and metrics server on the spoke
pre-commit run -awith this PRAdditional Notes