Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Map the Terraform entity into the cluster as admin to allow deploying Kubernetes, Helm, and Kubectl resources via providers #1878

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Feb 9, 2024

Description

  • Map the Terraform entity into the cluster as admin to allow deploying Kubernetes, Helm, and Kubectl resources via providers

Motivation and Context

  • The entity that is executing Terraform commands needs to have access inside the cluster to allow the Kubernetes, Kubectl, and Helm providers to provision the resources they create. Prior to cluster access entry, Terraform was automatically granted these permissions because it was the cluster creator.

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

…oying Kubernetes, Helm, and Kubectl resources via providers
@bryantbiggs bryantbiggs requested a review from a team as a code owner February 9, 2024 16:42
@askulkarni2 askulkarni2 merged commit b4b99d0 into main Feb 9, 2024
6 checks passed
@askulkarni2 askulkarni2 deleted the fix/bootstrap-admin branch February 9, 2024 16:53
@@ -1,4 +1,8 @@
```sh
# Necessary to avoid removing Terraform's permissions too soon before its finished
# cleaning up the resources it deployed inside the cluster
terraform state rm 'module.eks.aws_eks_access_entry.this["cluster_creator_admin"]' || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for those of us running atlantis, this step is a major restriction :(
can we look into a better alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants