chore: Add support for autoformatting YAML and spell checking via pre-commit hooks #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
force-pushed
the
chore/formatting
branch
from
e486da2 to
b6984f8
Compare
askulkarni2
approved these changes
Feb 5, 2024
| cert-manager cert-manager-87f5555f-tcxj7 1/1 Running 0 4h43m | ||
| cert-manager cert-manager-cainjector-8448ff8ddb-wwjsc 1/1 Running 0 4h43m | ||
| cert-manager cert-manager-webhook-5468b675b-fvdwk 1/1 Running 0 4h43m | ||
| cert-manager cert-manager-87f5555f-t1xj7 1/1 Running 0 4h43m |
There was a problem hiding this comment.
the spell checker isn't super great - if it sees 4 or more characters in a row it will treat it as a word. so something like cert-manager-87f5555f-tcxj7 will fail spell check but if you break it up with a numeric value like cert-manager-87f5555f-t1xj7 it ignores it 🤷🏽 (looking at just the last part after the last hyphen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How was this change tested?
pre-commit run -awith this PRAdditional Notes